WebUI: enforce coding styles #20828
Open
WebUI: enforce coding styles #20828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Chocobo1
commented
May 11, 2024
•
Chocobo1
commented
- WebUI: enforce string quotes coding style
- WebUI: enforce usage of const whenever possible
- WebUI: prefer arrow function in callbacks
- WebUI: use assignment operator shorthand
- WebUI: iterate over own properties only
- WebUI: simplify code
- WebUI: don't auto infer radix parameter
- WebUI: add missing break
Chocobo1
added
WebUI
Piccirello
previously approved these changes
May 11, 2024
| @@ -30,6 +30,7 @@ export default [ | |||
| "no-undef": "off", | |||
| "no-unused-vars": "off", | |||
| "no-var": "error", | |||
| "prefer-arrow-callback": "error", | |||
There was a problem hiding this comment.
Wanted to note that if any of these callbacks use this, the behavior will change with this commit. I haven't gone through to audit usage of this.
|
Please merge #20705 before this 😬 |
|
PR updated, resolved merge conflicts. |
glassez
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.