Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add four new icons to the View menu #20406

Closed
wants to merge 1 commit into from
Closed

Add four new icons to the View menu #20406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/gui/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ MainWindow::MainWindow(IGUIApplication *app, WindowState initialState)
m_ui->actionManageCookies->setIcon(UIThemeManager::instance()->getIcon(u"browser-cookies"_s, u"preferences-web-browser-cookies"_s));
m_ui->menuLog->setIcon(UIThemeManager::instance()->getIcon(u"help-contents"_s));
m_ui->actionCheckForUpdates->setIcon(UIThemeManager::instance()->getIcon(u"view-refresh"_s));
m_ui->actionRSSReader->setIcon(UIThemeManager::instance()->getIcon(u"rss"_s));
m_ui->actionShowFiltersSidebar->setIcon(UIThemeManager::instance()->getIcon(u"view-sidetree"_s));
m_ui->actionSpeedInTitleBar->setIcon(UIThemeManager::instance()->getIcon(u"speedometer"_s));
m_ui->actionSearchWidget->setIcon(UIThemeManager::instance()->getIcon(u"search"_s));
Comment on lines +176 to +179
Copy link
Member

@glassez glassez Feb 15, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, there are no such icons in qBittorrent sources (except "speedometer" one).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've just tested this on windows & here are the results:

Before This PR:
checkboxes/icons are all aligned vertically
Screenshot 2024-02-16 112209

With this PR:
Only the speedometer is added & it takes the place of the checkbox!
Screenshot 2024-02-16 112243

speedometer - clicked/enabled
Screenshot 2024-02-16 112310

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buckmelanoma why are the results different than yours ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buckmelanoma why are the results different than yours ?

Because they use icons from Linux theme.


auto *lockMenu = new QMenu(m_ui->menuView);
lockMenu->addAction(tr("&Set Password"), this, &MainWindow::defineUILockPassword);
Expand Down