-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user configuration file /usr/preferences.json #435
base: master
Are you sure you want to change the base?
Conversation
- A json file describing input/output data and protocol units with reference to the example implementation and example dataset. - When a new model added, this file must be updated. - To be added to the documentation
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 47.40% 46.49% -0.91%
==========================================
Files 260 272 +12
Lines 8647 9629 +982
==========================================
+ Hits 4099 4477 +378
- Misses 4548 5152 +604
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Purpose is to totally isolate user choices from native implementation choices. Config files provided by usr/devs will deal with necessary conversions.
|
Function |
@jvelazquez-reyes if you have time, maybe you can try having qMRLab/src/Common/modelRegistry.m Line 70 in bd22f11
qMRLab/src/Common/modelRegistry.m Line 98 in bd22f11
qMRLab/src/Common/modelRegistry.m Line 207 in bd22f11
If you can, please branch out from |
The main functionality to change input/output map units and input protocol parameters is ready. Here's an example, More fantastic configs are easily possible. For example, input parameters are in (usec) and the output map is in hrs 😁 Dealing with all these unit mappings is actually much trickier than it looks without inducing overhead to the voxelwise models. Tests will fail for a while, because I still need to go through classdefs of all the models. Then we'll decide on the default unified input/output units across models. Unified parameters will be enabled for users and documentation generation (because they'll be in the qMRgenBatch outputs or in GUI panel), but will be disabled for the unit tests. I know that a json of SI units exists out there, but there are reasons why I come up with a customized unit definition schema. The documentation will make it clear which units are available and changing which unit parents (e.g. |
- Move scaling functions from Abstract model to outside - Wrap Prot scaling around the FitData and ParFitData
- A proper BIDS entrypoint - Handling data merge use cases
@agahkarakuzu if this PR is ready for review, can you assign me and @jvelazquez-reyes ? If it isn't ready for review, can you detail what is missing? Maybe one of us can work towards resolving this PR in that case. |
Description to be added.