Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ftp downloading for older python versions #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mraspaud
Copy link
Member

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@mraspaud mraspaud added the bug label Sep 18, 2023
@mraspaud mraspaud self-assigned this Sep 18, 2023
@mraspaud
Copy link
Member Author

@TAlonglong if you want to have a look...

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #81 (77cb0f2) into main (885f7c2) will increase coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   38.85%   38.87%   +0.02%     
==========================================
  Files          15       15              
  Lines        2082     2086       +4     
==========================================
+ Hits          809      811       +2     
- Misses       1273     1275       +2     
Files Changed Coverage Δ
trollsched/satpass.py 64.22% <40.00%> (-0.16%) ⬇️

Copy link
Contributor

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problem with this change

@TAlonglong
Copy link
Contributor

Don't looks like I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants