Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS product and level1c collector #62

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ninahakansson
Copy link
Contributor

Add a PPS l1c collector that adds PPS lvl1c files to messages with PPS products

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest nwcsafpps_runner
  • Passes flake8 nwcsafpps_runner
  • Fully documented

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 66.33663% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 75.73%. Comparing base (5354d27) to head (cf08616).
Report is 27 commits behind head on main.

❗ Current head cf08616 differs from pull request most recent head 0fe3526. Consider uploading reports for the commit 0fe3526 to get more accurate results

Files Patch % Lines
nwcsafpps_runner/pps_collector_lib.py 0.00% 26 Missing ⚠️
nwcsafpps_runner/message_utils.py 79.48% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   74.24%   75.73%   +1.49%     
==========================================
  Files          15       17       +2     
  Lines        1778     1871      +93     
  Branches      266      164     -102     
==========================================
+ Hits         1320     1417      +97     
+ Misses        419      415       -4     
  Partials       39       39              
Flag Coverage Δ
unittests 75.73% <66.33%> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ninahakansson ninahakansson marked this pull request as ready for review May 16, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant