Handle sensor list in topic #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 91.23% 91.26% +0.02%
==========================================
Files 32 32
Lines 4417 4429 +12
==========================================
+ Hits 4030 4042 +12
Misses 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8799660697Details
💛 - Coveralls |
adybbroe
reviewed
May 3, 2024
pytroll_collectors/scisys.py
Outdated
| """Update sensor tuples and lists to MULTIPLE_SENSORS.""" | ||
| to_send_dict = to_send.copy() | ||
| if "sensor" in to_send: | ||
| if type(to_send["sensor"]) is list or type(to_send["sensor"]) is tuple: |
There was a problem hiding this comment.
I think it is perhaps more pythonic to do isinstance(to_send["sensor"], collections.abc.Sequence)
?
There was a problem hiding this comment.
isinstance(to_send["sensor"], (list, tuple)) should also work
adybbroe
reviewed
May 3, 2024
pytroll_collectors/scisys.py
Outdated
| to_send_dict = to_send.copy() | ||
| if "sensor" in to_send: | ||
| if type(to_send["sensor"]) is list or type(to_send["sensor"]) is tuple: | ||
| to_send_dict["sensor"] = "MULTIPLE_SENSORS" |
There was a problem hiding this comment.
Should it be "multiple sensors" rather?
adybbroe
reviewed
May 3, 2024
|
Unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of list of sensor, use MULTIPLE_SENSORS in topic. We do not want a tuple or lsit in the publishing topic.