Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels with numpy 2 #70

Merged
merged 1 commit into from Feb 14, 2024
Merged

Build wheels with numpy 2 #70

merged 1 commit into from Feb 14, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 14, 2024

Until numpy 2 is fully released, the lines added in this PR in deploy.yaml are required to build a wheel that is compatible with numpy 1 and numpy 2. Once numpy 2 comes out we should be able to remove those lines.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added enhancement dependencies Pull requests that update a dependency file labels Feb 14, 2024
@djhoese djhoese self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aef458a) 88.31% compared to head (09c9061) 88.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          21       21           
  Lines        1464     1464           
=======================================
  Hits         1293     1293           
  Misses        171      171           
Flag Coverage Δ
unittests 88.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.468%. remained the same
when pulling 09c9061 on djhoese:wheels-numpy2
into 74b1025 on pytroll:main.

@djhoese djhoese merged commit b9780dd into pytroll:main Feb 14, 2024
23 checks passed
@djhoese djhoese deleted the wheels-numpy2 branch February 14, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants