Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to test pypi only on tags #63

Merged
merged 1 commit into from Nov 28, 2023
Merged

Conversation

mraspaud
Copy link
Member

The deploy fails otherwise with invalid version number.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@mraspaud mraspaud added the bug label Nov 28, 2023
@mraspaud mraspaud self-assigned this Nov 28, 2023
@pnuu
Copy link
Member

pnuu commented Nov 28, 2023

Does this mean there's no need to create a release for the PyPI push to happen? I think the release is what triggers the upload in some other packages 🤔

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4710c1) 88.31% compared to head (59004f0) 88.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          21       21           
  Lines        1464     1464           
=======================================
  Hits         1293     1293           
  Misses        171      171           
Flag Coverage Δ
unittests 88.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.468%. remained the same
when pulling 59004f0 on mraspaud:fix-deploy-tag
into f4710c1 on pytroll:main.

@mraspaud
Copy link
Member Author

Does this mean there's no need to create a release for the PyPI push to happen? I think the release is what triggers the upload in some other packages 🤔

That's only for test pypi. Regular pypi only gets release versions. test pypi gets tagged versions, since we tag before we release.

@djhoese djhoese merged commit 62f3e26 into pytroll:main Nov 28, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants