Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python versions in deploy ci #62

Merged
merged 9 commits into from Nov 27, 2023

Conversation

mraspaud
Copy link
Member

This PR fixes the python versions for the deploy script of the ci

@mraspaud mraspaud added the bug label Nov 27, 2023
@mraspaud mraspaud self-assigned this Nov 27, 2023
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we keep 3 or four versions in other packages?

@pnuu
Copy link
Member

pnuu commented Nov 27, 2023

Hmm, 3.10 is not shown in the active checks.

@mraspaud
Copy link
Member Author

Idk, we have 3.9, 3.11, and 3.12 in the ci.yaml, so I wasn't really sure

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e8b790) 88.31% compared to head (e3c5063) 88.31%.

❗ Current head e3c5063 differs from pull request most recent head 87739e5. Consider uploading reports for the commit 87739e5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          21       21           
  Lines        1464     1464           
=======================================
  Hits         1293     1293           
  Misses        171      171           
Flag Coverage Δ
unittests 88.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud
Copy link
Member Author

we should have 3.10, 3.11 and 3.12 right?

@pnuu
Copy link
Member

pnuu commented Nov 27, 2023

The config now has 3.9, 3.10, 3.11 and 3.12, but the 3.10 is missing from the active tests.

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 87.468%. remained the same
when pulling 87739e5 on mraspaud:fix-deploy-version-numbers
into 2e8b790 on pytroll:main.

@@ -34,7 +34,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-latest, macos-latest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, where's "ubuntu-latest"? It is listed in current main: https://github.com/pytroll/python-geotiepoints/blob/main/.github/workflows/ci.yaml#L12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was deploy.yaml, not ci.yaml.

@mraspaud
Copy link
Member Author

Ok should be better now

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might as well drop Python 3.9 support in the setup.py then.

@djhoese
Copy link
Member

djhoese commented Nov 27, 2023

Whoa I didn't realize this package hadn't switched to cibuildwheel yet. We should really do that, but I'm not sure I have time today. Will look into it more after I've actually woken up.

@mraspaud
Copy link
Member Author

You might as well drop Python 3.9 support in the setup.py then.

Good point, on it.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge this, but leave any releases up to you unless you ask me to.

@djhoese djhoese merged commit 2103547 into pytroll:main Nov 27, 2023
21 checks passed
@mraspaud mraspaud deleted the fix-deploy-version-numbers branch November 28, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants