Fix VII interpolator compatibility with future versions of xarray #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 21 21
Lines 1438 1438
=======================================
Hits 1266 1266
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first noticed in pytroll/satpy#2416, there are failures for Satpy's VII reader tests when used with the unreleased version of xarray. Xarray is now more strict about using dask arrays for coordinates and indexing. The VII failure comes down to usage in this package and was a simple fix related to removing the use of dask. The arrays involved are relatively small and I think getting computed almost immediately by old xarray versions any way. This PR just converts everything to numpy.
CC @sjoro
git diff origin/main **/*py | flake8 --diff