Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slstr #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TAlonglong
Copy link

inst = np.tile(inst[:, np.newaxis, :], [1, np.int32(scans_nb), 1])

times = np.tile(np.zeros_like(scanline_angles), [np.int32(scans_nb), 1])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

"""Test the definition of the slstr instrument flying on Sentinel-3
"""
geom = slstr(1, [0, 1])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #98 (e8e2e26) into main (26e857b) will increase coverage by 0.03%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   86.86%   86.89%   +0.03%     
==========================================
  Files          13       13              
  Lines        2048     2068      +20     
==========================================
+ Hits         1779     1797      +18     
- Misses        269      271       +2     
Flag Coverage Δ
unittests 86.89% <90.47%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyorbital/geoloc_instrument_definitions.py 72.61% <85.71%> (+1.28%) ⬆️
pyorbital/tests/test_geoloc.py 94.64% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e857b...e8e2e26. Read the comment docs.

@TAlonglong
Copy link
Author

Could someone add appropriate tags to this issue? And who can review this?

@TAlonglong
Copy link
Author

This PR is needed before issue 69 in pytroll-schedule can reviewed.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, just a couple of comments

@@ -553,3 +553,33 @@ def ascat(scan_nb, scan_points=None):
[np.int32(scan_nb), 1]) + np.expand_dims(offset, 1))

return ScanGeometry(inst, times)


def slstr(scans_nb, scan_points=None, is_nadir=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called eg slstr_nadir?


if scan_points is None:
scan_len = 3000 # samples per scan
scan_points = np.arange(3000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scan_points = np.arange(3000)
scan_points = np.arange(scan_len)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be tested also.

@adybbroe
Copy link
Contributor

@TAlonglong
Do you have time looking at this again, see comments above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants