Add NOAA-21 support #118
Open
Add NOAA-21 support #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…txt file Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
…e automated bots for checking code quality and tests Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 87.51% 87.81% +0.29%
==========================================
Files 15 15
Lines 2211 2248 +37
==========================================
+ Hits 1935 1974 +39
+ Misses 276 274 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
While working with this PR and upgrading our systems for NOAA-21 at SMHI we realized that there seem to be a bug here, standing in the way of updating support for NOAA-21, see #119 |
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
# Conflicts: # pyorbital/tests/test_tlefile.py # pyorbital/tlefile.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding NOAA-21 to the list of designators/ids in the built in platforms.txt file
This was actually already included in #113 but that PR is about environment variables and is also not yet ready and merged.