[JIT] greedy by size memory planning strategy #64349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit fd9cd4a (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Lint / clang-format |
Run clang-format | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Sep 1, 2021
Closed
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic [ghstack-poisoned]
|
@makslevental has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
added 3 commits
September 6, 2021 20:41
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
makslevental
requested review from
desertfire,
Krovatkin,
d1jang and
eellison
added 3 commits
September 12, 2021 17:32
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
Krovatkin
reviewed
Sep 22, 2021
| makeAllocation(ulvr, size, ordered_allocations, findOffsetWithSmallestGap); | ||
| } | ||
|
|
||
| auto cmp = liveRangeStartCmp(); |
There was a problem hiding this comment.
to double check, cmp returns a boolean and not -1, 0, 1?
There was a problem hiding this comment.
@Krovatkin that's correct
| [&cmp](auto m1, auto m2) { return cmp(m1.ulvr, m2.ulvr); }); | ||
| return ordered_allocations; | ||
| } | ||
|
|
There was a problem hiding this comment.
we seem to be missing greedyBySizeWithSmallestGap or is it somehow covered the other two?
There was a problem hiding this comment.
@Krovatkin hmm not sure what version you were looking at but it's in this commit
| [&cmp](auto& p1, auto& p2) { | ||
| auto len1 = p1.first.lvr.end - p1.first.lvr.begin; | ||
| auto len2 = p2.first.lvr.end - p2.first.lvr.begin; | ||
| return len1 == len2 ? (p1.second == p2.second ? cmp(p1.first, p2.first) |
There was a problem hiding this comment.
I'd suggest to assign .second , .first into temps with descriptive names, otherwise it's a bit hard to reason about what those are. Looks like .second is size?
There was a problem hiding this comment.
cmp(p1.first, p2.first) would this also be in an non-increasing order or it doesn't matter?
There was a problem hiding this comment.
@Krovatkin *.first are the "unique" live ranges. we're sorting here by length and then breaking ties by size and start. it's convoluted i admit but it happens and it's very frustrating dealing with non-deterministic orderings when debugging.
| std::sort( | ||
| sorted_length_then_size_live_ranges.begin(), | ||
| sorted_length_then_size_live_ranges.end(), | ||
| [&cmp](auto& p1, auto& p2) { |
There was a problem hiding this comment.
nit: maybe we could encapsulate this into its own comparator.
a) you won't have to pass &cmp
b) a reader won't have to read the same code twice if they don't realize the sorting order is the same.
| } | ||
|
|
||
| // don't simplify this to gap = a - b because you'll get buffer overflow... | ||
| if (alloc.reg.offset >= prev_offset) { |
There was a problem hiding this comment.
when would this case happen you seem to be inserting in the order of increasing offsets in makeAllocation?
There was a problem hiding this comment.
@Krovatkin good catch - it's true this doesn't make sense in this function (findFirstOffset) but it has since been refactored and makes more sense in context
| size_t prev_offset = 0; | ||
|
|
||
| for (const auto& alloc : ordered_allocations) { | ||
| if (!overlapLiveRange(alloc.ulvr, unalloced_ulvr)) { |
There was a problem hiding this comment.
I'm a bit confused here. It looks like we are skipping live ranges that don't overlap with the unallocated live range?
I was thinking we should be specifically looking for the ranges that do not overlap otherwise we can't reuse that storage?
There was a problem hiding this comment.
@Krovatkin this is looking for live ranges that overlap in time and then finding the smallest gap between these "live" live ranges. this should really be done using something like an interval tree (and an overlap lookup). I'm looking into this but one issue is interval trees don't deal well with duplicated endpoints. In the single-threaded case that's not an issue but in the concurrency case it might pop up.
Greedy by size (a heuristic that allocates largest tensors first) based on [this paper]( https://arxiv.org/pdf/2001.03288.pdf). It's factored the way it is for the purposes of making subsequent strategies simpler to implement. make greedy deterministic Differential Revision: [D30769096](https://our.internmc.facebook.com/intern/diff/D30769096) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
|
@makslevental has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Hi @makslevental! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Greedy by size (a heuristic that allocates largest tensors first) based on this paper. It's factored the way it is for the purposes of making subsequent strategies simpler to implement.
make greedy deterministic
Differential Revision: D30769096