-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete refactored function, move changes over #126407
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesjwu
added a commit
that referenced
this pull request
May 16, 2024
ghstack-source-id: c1920af3f800b5d28d8d5dc7d828321cf6b1f9c0 Pull Request resolved: #126407
jamesjwu
added
ciflow/trunk
Trigger trunk jobs on your pull request
topic: not user facing
topic category
labels
May 16, 2024
eellison
approved these changes
May 16, 2024
jamesjwu
added a commit
that referenced
this pull request
May 16, 2024
ghstack-source-id: 5484bfcc35f8b893db6a9a4167ecc31d7925952b Pull Request resolved: #126407
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced May 16, 2024
@pytorchbot merge -i |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Oops, in pytorch#125610 I moved this function to runtime_wrappers.py, but forgot to delete the old one. pytorch#126234 then modified it which would do nothing, so I'm applying the change correctly now and deleting the function as I intended. Pull Request resolved: pytorch#126407 Approved by: https://github.com/eellison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Oops, in #125610 I moved this function to runtime_wrappers.py, but forgot to delete the old one. #126234 then modified it which would do nothing, so I'm applying the change correctly now and deleting the function as I intended.