Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete refactored function, move changes over #126407

Closed
wants to merge 2 commits into from

Conversation

jamesjwu
Copy link
Contributor

@jamesjwu jamesjwu commented May 16, 2024

Stack from ghstack (oldest at bottom):

Oops, in #125610 I moved this function to runtime_wrappers.py, but forgot to delete the old one. #126234 then modified it which would do nothing, so I'm applying the change correctly now and deleting the function as I intended.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126407

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 838ba4e with merge base failed to retrieve merge base, please contact dev infra:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jamesjwu added a commit that referenced this pull request May 16, 2024
ghstack-source-id: c1920af3f800b5d28d8d5dc7d828321cf6b1f9c0
Pull Request resolved: #126407
@jamesjwu jamesjwu requested review from ezyang and eellison May 16, 2024 16:16
@jamesjwu jamesjwu marked this pull request as ready for review May 16, 2024 16:16
@jamesjwu jamesjwu added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels May 16, 2024
[ghstack-poisoned]
jamesjwu added a commit that referenced this pull request May 16, 2024
ghstack-source-id: 5484bfcc35f8b893db6a9a4167ecc31d7925952b
Pull Request resolved: #126407
@jamesjwu
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jamesjwu
Copy link
Contributor Author

@pytorchbot merge -i

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
Oops, in pytorch#125610 I moved this function to runtime_wrappers.py, but forgot to delete the old one. pytorch#126234 then modified it which would do nothing, so I'm applying the change correctly now and deleting the function as I intended.

Pull Request resolved: pytorch#126407
Approved by: https://github.com/eellison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants