[optim] Fix: wrong ASGD implementation #126375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case is able to identify the step issue.
This test case passed before due to the numerical problem.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126375
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5c1436e with merge base d2f5a8a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
approved these changes
May 17, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
This PR is based on pytorch#125440, additionally merging the latest main branch and fixing the lint failures from pytorch#126361. Pull Request resolved: pytorch#126375 Approved by: https://github.com/janeyx99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #125440, additionally merging the latest main branch and fixing the lint failures from #126361.