[Inductor] Properly package target info for triton.compile #125241
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125241
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aeabcb2 with merge base ab80a59 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
cpuhrsch
added
the
triaged
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Sorry for reverting your change but it is failing inductor tests on ROCm https://hud.pytorch.org/pytorch/pytorch/commit/8a1af95b0979d85c4fe32a75e797323ad81f298d' -c nosignal I will add |
|
Oh, the branch has been deleted, so if you try to reland the change in a different PR, please add |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@alexbaden your PR has been successfully reverted. |
…125241)" This reverts commit 8a1af95. Reverted #125241 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing inductor tests on ROCm https://hud.pytorch.org/pytorch/pytorch/commit/8a1af95b0979d85c4fe32a75e797323ad81f298d ([comment](#125241 (comment)))
…25241) Triton updated the interface for `triton.compile` triton-lang/triton@5162346 The `target` argument to compile needs to be wrapped in a `GPUTarget` object. Without proper wrapping, we hit an assert in `compile`. If that assert is removed, Triton attempts to read device info from Torch while inside a torch thread, which hits an in bad fork assert. This change is required for compatibility with latest commits in Triton. The implementation is backwards compatible, so existing versions of Triton that work now continue to work. Pull Request resolved: pytorch#125241 Approved by: https://github.com/jansel
|
I think I might revert this wrongly as the failure still occurs after the revert https://hud.pytorch.org/pytorch/pytorch/commit/6d30803d64953955df63da56833bf4eb52249aae. Let me know when you want to reland the change, I can stamp and land it. |
|
Do you want me to open a new PR? GitHub is not letting me reopen this one, possibly because the original branch was deleted. |
Creating a new PR is ok. |
…25241) Triton updated the interface for `triton.compile` triton-lang/triton@5162346 The `target` argument to compile needs to be wrapped in a `GPUTarget` object. Without proper wrapping, we hit an assert in `compile`. If that assert is removed, Triton attempts to read device info from Torch while inside a torch thread, which hits an in bad fork assert. This change is required for compatibility with latest commits in Triton. The implementation is backwards compatible, so existing versions of Triton that work now continue to work. Pull Request resolved: pytorch#125241 Approved by: https://github.com/jansel
|
Re-submitted as #125553 |
Triton updated the interface for `triton.compile` triton-lang/triton@5162346 The `target` argument to compile needs to be wrapped in a `GPUTarget` object. Without proper wrapping, we hit an assert in `compile`. If that assert is removed, Triton attempts to read device info from Torch while inside a torch thread, which hits an in bad fork assert. This change is required for compatibility with latest commits in Triton. The implementation is backwards compatible, so existing versions of Triton that work now continue to work. Re-submitting this after #125241 was reverted due to an unrelated CI issue. Pull Request resolved: #125553 Approved by: https://github.com/huydhn
Triton updated the interface for
triton.compiletriton-lang/triton@5162346The
targetargument to compile needs to be wrapped in aGPUTargetobject. Without proper wrapping, we hit an assert incompile. If that assert is removed, Triton attempts to read device info from Torch while inside a torch thread, which hits an in bad fork assert. This change is required for compatibility with latest commits in Triton. The implementation is backwards compatible, so existing versions of Triton that work now continue to work.cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire