Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ncclx] Rename NCCL-EXP to NCCLX #125238

Closed
wants to merge 1 commit into from
Closed

[ncclx] Rename NCCL-EXP to NCCLX #125238

wants to merge 1 commit into from

Conversation

wesbland
Copy link
Contributor

@wesbland wesbland commented Apr 30, 2024 •
edited by pytorch-bot bot

@wesbland @facebook-github-bot
[ncclx] Rename NCCL-EXP to NCCLX
3d95831 
Reviewed By: kryanchun

Differential Revision: D56534548
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 30, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @wesbland, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Apr 30, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 30, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125238

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d95831 with merge base ab80a59 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 30, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@wesbland @petrex
[ncclx] Rename NCCL-EXP to NCCLX (#125238)
b2299de 
Reviewed By: kryanchun

Differential Revision: D56534548

Pull Request resolved: #125238
Approved by: https://github.com/kwen2501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wesbland @facebook-github-bot @pytorchmergebot @kwen2501