Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOTI] Update C-shim codegen to handle rocm #125233

Closed
wants to merge 1 commit into from

Conversation

desertfire
Copy link
Contributor

@desertfire desertfire commented Apr 30, 2024

Stack from ghstack (oldest at bottom):

Summary: Instead of hipifying generated C shim files, we change the torchgen script to generate hipified code.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

Summary: Instead of hipifying generated C shim files, we change the torchgen script to generate hipified code.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125233

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 4 Unrelated Failures

As of commit be35743 with merge base da44d2f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Apr 30, 2024
desertfire added a commit that referenced this pull request Apr 30, 2024
Summary: Instead of hipifying generated C shim files, we change the torchgen script to generate hipified code.

ghstack-source-id: a0b0342917bbbc65afabe1740d667a066978a1ab
Pull Request resolved: #125233
@desertfire desertfire closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm module: rocm AMD GPU support for Pytorch topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant