Fix random_mps_impl to accept non-contiguous tensors

[lamroger]

Fixes #124029

Follows the pattern of allocating contiguous memory and copying the results in https://github.com/pytorch/pytorch/pull/123049/files

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125231

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 4 Unrelated Failures

As of commit 3b7efae with merge base b03fb49 ():

NEW FAILURES - The following jobs have failed:

• trunk / linux-focal-rocm6.0-py3.8 / test (default, 1, 1, linux.rocm.gpu) (gh)
  test_ops.py::TestCommonCUDA::test_variant_consistency_eager_bernoulli_cuda_float32
• trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-stable) (gh)
  test_ops.py::TestCommonCPU::test_variant_consistency_eager_bernoulli_cpu_float32
• trunk / macos-12-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh)
  test_ops.py::TestCommonCPU::test_noncontiguous_samples_bernoulli_cpu_float32
• trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) (gh)
  test_ops.py::TestTagsCPU::test_tags_bernoulli_cpu_float32
• trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral) (gh)
  test_ops.py::TestCommonCPU::test_variant_consistency_eager_bernoulli_cpu_float32

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge) (gh) (disabled by #104012 but the issue was closed recently and a rebase is needed to make it pass)
  test_fx.py::TestFXAPIBackwardCompatibility::test_public_api_surface
• trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge) (gh) (disabled by #104012 but the issue was closed recently and a rebase is needed to make it pass)
  test_fx.py::TestFXAPIBackwardCompatibility::test_public_api_surface
• trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (disabled by #104012 but the issue was closed recently and a rebase is needed to make it pass)
  test_fx.py::TestFXAPIBackwardCompatibility::test_public_api_surface
• trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) (gh) (disabled by #104012 but the issue was closed recently and a rebase is needed to make it pass)
  test_fx.py::TestFXAPIBackwardCompatibility::test_public_api_surface

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[lamroger]

random_mps_impl is used in other operations in Distribution. Should I add tests for those too?
cc: @kulinseth since I followed your suggestion here: #120272 (review) and think the same advice applies here

[kulinseth]

Looks good.

[lamroger]

@pytorchbot merge

[pytorch-bot]

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

[lamroger]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Successfully rebased roger/non-contiguous-rand-like onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout roger/non-contiguous-rand-like && git pull --rebase)

[lamroger]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64-mps / test (mps, 1, 1, macos-m1-stable)

Details for Dev Infra team

Raised by workflow job

[lamroger]

Hey @kulinseth , wanted to double check removing this test is okay since we can accept multiple elements referencing the same location now

[kulinseth]

Why was this test removed ?

[lamroger]

bernuoulli uses random_mps_impl under the hood so the error wasn't valid anymore since it support non-contiguous tenors now too. So I removed it but on second thought, it might be useful to keep the test as a passing test for documentation.

I added it back to the sample_inputs_bernoulli method. Open to other ideas too!