Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to find sbgemm in BLAS library #125227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vinithakv
Copy link
Contributor

@vinithakv vinithakv commented Apr 30, 2024

Current logic to set the HAS_SBGEMM flag is ignored in case the BLAS libraries are found already, ie, if set from environment variable BLAS=OpenBLAS . If BLAS_LIBRARIES are already set the code to find if BLAS_LIBRARY has sbgemm is never executed. The following commit brings out this logic outside unconditionally.

Fixes #ISSUE_NUMBER

cc @frank-wei @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Current logic to set the HAS_SBGEMM flag is ignored in case the BLAS libraries are found
already, ie, if set from environment variable BLAS=OpenBLAS .
If BLAS_LIBRARIES are already set the code to find if BLAS_LIBRARY has sbgemm is never executed.
The following commit brings out this logic outside unconditionally.
Copy link

pytorch-bot bot commented Apr 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125227

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 5416fac with merge base f7f018a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cpuhrsch cpuhrsch requested a review from malfet April 30, 2024 19:52
@cpuhrsch cpuhrsch added module: intel Specific to x86 architecture triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 30, 2024
@vinithakv
Copy link
Contributor Author

Hi,
Requesting for review .

Regards,
Vinitha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: intel Specific to x86 architecture open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants