fix loading optimizer options from archive #125215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125215
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ca188ac with merge base e0d2c24 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cpuhrsch
added
the
triaged
janeyx99
reviewed
May 2, 2024
|
@janeyx99 I update the existing test for optimizer serializing. Now the test passes with the proposed patch but fails without it. |
janeyx99
approved these changes
May 6, 2024
test/cpp/api/serialize.cpp
Outdated
| const double lr = param_group.options().get_lr(); | ||
| // change the learning rate, which will be overwritten by the loading | ||
| // otherwise, test cannot check if options are saved and loaded correctly | ||
| param_group.options().set_lr(lr + 1); |
There was a problem hiding this comment.
lrs are usually sub 1 haha, can we change this to + .01?
There was a problem hiding this comment.
Okay. I change it to 0.01
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes libtorch behave the same as PyTorch when loading optimizer state from archive. With PyTorch, options of parameter groups are loaded from the archive, which is missing currently in libtorch.