Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in get_update_constraint #125194

Closed
wants to merge 1 commit into from
Closed

Fix bug in get_update_constraint #125194

wants to merge 1 commit into from

Conversation

tugsbayasgalan
Copy link
Contributor

Summary: Title

Test Plan: CI

Differential Revision: D56726321

@tugsbayasgalan @facebook-github-bot
Fix bug in get_update_constraint
097a0c4 
Summary: Title

Test Plan: CI

Differential Revision: D56726321
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 29, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125194

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 097a0c4 with merge base faee0e5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pianpwk pianpwk self-requested a review April 30, 2024 17:38
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 30, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@tugsbayasgalan @andoorve
Fix bug in get_update_constraint (pytorch#125194)
306f3f9 
Summary: Title

Test Plan: CI

Differential Revision: D56726321

Pull Request resolved: pytorch#125194
Approved by: https://github.com/pianpwk
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@tugsbayasgalan @petrex
Fix bug in get_update_constraint (pytorch#125194)
8b64e77 
Summary: Title

Test Plan: CI

Differential Revision: D56726321

Pull Request resolved: pytorch#125194
Approved by: https://github.com/pianpwk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pianpwk pianpwk pianpwk approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm gmagogsfm is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tugsbayasgalan @facebook-github-bot @pytorchmergebot @pianpwk