Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WeightOnlyInt8QuantLinear more compatible with torch.compile #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make WeightOnlyInt8QuantLinear more compatible with torch.compile #19

wants to merge 2 commits into from

Conversation

cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented Dec 3, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2023
@HDCharles
Copy link
Contributor

may be good to align the forward method with the tensor subclass as well.

HDCharles
HDCharles reviewed Dec 5, 2023
View reviewed changes
torchao/quantization/weight_only.py
)
new_mod.register_buffer("w_int8", w_int8.t())
new_mod.scales = torch.nn.Parameter(scales)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want requires_grad = False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDCharles HDCharles HDCharles left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpuhrsch @HDCharles @facebook-github-bot