Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix deconv kernel channel num_output_maps where wts are ITensor #2678

Merged
merged 1 commit into from May 22, 2024

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Mar 8, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
In current implementation deconv layer picks up the in_channel for kernel incorrectly when weight is also an ITensor.
This PR fixes that issue.

Conv2d
ConvTranspose2d

For conv2d the kernel dimensions are: [out_channels, in_channels / group, ... ]
For convTranspose2d the kernel dimension should be: [in_channel, out_channels / group, ... ]

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters labels Mar 8, 2024
@github-actions github-actions bot requested a review from narendasan March 8, 2024 18:07
@andi4191
Copy link
Contributor Author

Hi @bowang007

Request you to please review this PR for merge?

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. I verified the test passes on local

@peri044 peri044 merged commit 101fac6 into pytorch:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants