Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start working on the practicalities section. #55

Merged
merged 9 commits into from Apr 19, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
@@ -1,2 +1,3 @@
_site/
.DS_Store
.DS_Store
*.swo
1 change: 1 addition & 0 deletions _config.yml
Expand Up @@ -35,4 +35,5 @@ colors:

collections:
- sections
- practicalities

119 changes: 119 additions & 0 deletions _practicalities/intro.md
@@ -0,0 +1,119 @@
---
---


Add note here to explain that this does _not_ prevent _nor_ discourage library
author to release 2 version of their software one Python 3 only and the other
python 2.

This actually made the above easier and less-likely to break.


# As a user

If you are already a Python 3 user, you should not encounter a lot of
disruption. Please check that the libraries you use follow best practices not
to break for Python 3 users.

Make sure you have Pip >= 9.0

If you are using a custom local package index, for example if you are working
at a company, make sure it implement correctly pep-512 and let pip knows about
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP 512 is the GitHub migration, so I think you may mean another PEP.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, sorry. I'll fix that to 503 :-)

the `python_requires` field.




# Preparing your library

Things to speak about:

- Be on recent enough setuptools, since [This
PR](https://github.com/pypa/setuptools/pull/631), 24.2.0 (or above, July 20,
2016, Xavier Fernandez PR.)

Add the followign to your setup.py

```
setup(
...
python_requires='>=3.3'
...
)
```

change >=



- Add a warning at _runtime_ early on master (before switching to Python 3
only)

```
import warnings
import sys
if sys.version_info < (3,):
warnings.warn('You are using master of `Frobulator` with Python 2. Frobulator will soon be Python 3 only. See this issue to know more.', UserWarning)
else:

```

- Add an error early at import at runtime with a clear error message, leave the
early import compatible Python 2 for users to not be welcomed with a useless `SyntaxError`.
You are _allowed_ to use multiline strings in error messages.


```
import sys

if sys.version_info < (3,):
Raise ValueError(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be lower case raise here

"""You are running Frobulator 6.0 on Python 2

Unfortunately Frobulator 6.0 and above re not compatible with Python 2 anymore,
and you still ended up with this version installed on your system. That's a
bummer sorry about that it should not have happen. Make sure you have pip >=
9.0 to avoid this kind of issues:

$ pip install pip --upgrade

Use the followign to check pip version

You have various choices:

- You can still install an older version of Frobulator:
$ pip install frobulator<6.0

- Upgrade your system to use Python 3.

It would be great if you can figure out how this version ended up being
installed, and try to check how to prevent that for future users.

This this page for more information : url to here for example.
""")



- Make sure your version number match pep440 or you will get surprises during
beta in particular as the `sdist` and `wheel` will appear as being different
versions, in particular sdist (during beta/rc/post) might appear with a
greater version number than wheels... and pip will try to install the sdist
instead of the wheel... The regular expression is trickier than expected:

`^([1-9]\\d*!)?(0|[1-9]\\d*)(\\.(0|[1-9]\\d*))*((a|b|rc)(0|[1-9]\\d*))?(\\.post(0|[1-9]\\d*))?(\\.dev(0|[1-9]\\d*))?`



# Mitigations

- Leave `setup.py` python 2 compatible and fail early. If you detect Python 2
raise a clear error message and ask user to make sure they have pip >9.0 (or
migrate to Python 3). You can (try to) conditionally import pip and check for
its version but this might not be the same pip.

- If you control dependant packages, Make sure to include conditional
dependencies depending on the version of Python.




33 changes: 33 additions & 0 deletions practicalities/index.html
@@ -0,0 +1,33 @@
---
---
<!DOCTYPE html>
<html dir="ltr" lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>{{ site.title }}</title>
<meta name="keywords" content="{{ site.keywords }}">
<meta name="description" content="{{ site.description }}">
<link rel="stylesheet" href="../combo.css">
<link href='https://fonts.googleapis.com/css?family=Raleway:400,300,700' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="https://netdna.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/vis/4.16.1/vis.min.css">
<script src="https://cdnjs.cloudflare.com/ajax/libs/vis/4.16.1/vis.min.js"></script>
{% if site.favicon %}<link rel="shortcut icon" href="{{ site.favicon }}" type="image/x-icon">{% endif %}
{% if site.touch_icon %}<link rel="apple-touch-icon" href="{{ site.touch_icon }}">{% endif %}
</head>
<body>
<div id="main">


{% for page in site.practicalities %}
<div class="section">

<div class="container {{ page.style }}">
{{ page.content }}
</div>
</div>
{% endfor %}
</div>
</body>