Modernize packaging a bit #38
Conversation
setup.cfg
Outdated
| @@ -1,2 +1,32 @@ | |||
| [bdist_wheel] | |||
| universal=0 | |||
| [metadata] | |||
There was a problem hiding this comment.
Might as well put this config in pyproject.toml?
There was a problem hiding this comment.
I don't have python 3.5 installed, but I suspect it won't work with it. I'll try getting py3.5 and check it though.
There was a problem hiding this comment.
We can drop 3.5, 3.6 and 3.7 support
There was a problem hiding this comment.
@hauntsaninja great, that might help. I'll send a PR to do this first.
Adding pyproject.toml allows the package to be installed using PEP517 instead of legacy `setup.py install` method. At least pip says so in a warning when installing without the `wheel` package available. Change setup.py to setup.cfg (using a script[0]) because setup.py is out of fashion these days. Remove MANIFEST.ini since LICENSE is implied[1]. [0] https://github.com/gvalkov/setuptools-py2cfg [1] https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-license-files
bluetech
force-pushed
the
modernize-packaging
branch
from
fb504bf
to
780aa14
Compare
Supported since setuptools 61.0.0, more standard.
bluetech
force-pushed
the
modernize-packaging
branch
from
0601a1f
to
aad9410
Compare
|
Changed from setup.cfg to pyproject.toml, seems to work. Added it in a separate commit just in case.
|
Adding pyproject.toml allows the package to be installed using PEP517 instead of legacy
setup.py installmethod. At least pip says so in a warning when installing without thewheelpackage available.Change setup.py to setup.cfg (using a script[0]) because setup.py is out of fashion these days.
Remove MANIFEST.ini since LICENSE is implied[1].
[0] https://github.com/gvalkov/setuptools-py2cfg
[1] https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-license-files