Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Remove outdated yum instructions #1318

Merged
merged 7 commits into from May 10, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 8, 2024

Similar to #1317.

For example, yum has short instructions:

image

As does DNF:

image

But apt is much longer, so it's good to tidy it away when not relevant:

image


📚 Documentation preview 📚: https://cpython-devguide--1318.org.readthedocs.build/getting-started/setup-building/#install-dependencies

@hugovk hugovk changed the title Linux: Add tabs for yum/DNF/apt Linux: Add tabs for yum/DNF/apt May 8, 2024
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
getting-started/setup-building.rst Outdated Show resolved Hide resolved
@encukou
Copy link
Member

encukou commented May 9, 2024

I think we should not hide Ubuntu under “apt” -- there are people who don't know their system's package manager, and they're likely to be using Ubuntu :)

@hugovk
Copy link
Member Author

hugovk commented May 9, 2024

Sure, shall we remove yum and rename the other tabs "Fedora" and "Debian & Ubuntu"?

Or something like "Fedora (dnf)" and "Debian & Ubuntu (apt)"?

hugovk and others added 3 commits May 9, 2024 08:06
@hugovk
Copy link
Member Author

hugovk commented May 9, 2024

And which tab should come first? Do we have an idea of which distros our readers use most?

Random website stats https://truelist.co/blog/linux-statistics/ say:

  • apt: Ubuntu + Debian + CentOS = 49.9%
  • DNF: CentOS + Red Hat + Fedora = 10.3%

Suggesting we should flip the order.

@encukou
Copy link
Member

encukou commented May 9, 2024

If you remove yum, there are two left: one that's very short, and one that's more widely used.
IMO, the best presentation for that is regular sections rather than tabs, with the short one first so it's obvious that another section follows.

@hugovk hugovk changed the title Linux: Add tabs for yum/DNF/apt Linux: Remove outdated yum instructions May 9, 2024
@hugovk
Copy link
Member Author

hugovk commented May 9, 2024

Updated!

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, simple is best :)

getting-started/setup-building.rst Outdated Show resolved Hide resolved
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@hugovk
Copy link
Member Author

hugovk commented May 10, 2024

Yes, reverted the original change but we nevertheless end up with better docs :)

@hugovk hugovk merged commit f7dd3b0 into python:main May 10, 2024
4 checks passed
@hugovk hugovk deleted the linux-tabs branch May 10, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants