gh-118351: Adopt support.TEST_MODULES_ENABLED for Windows build
#118354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI/CD failure is not related to this change. We should have seen this earlier, but the tests were skipped. |
|
Unfortunately, we can't merge this with the tests broken. If you can figure out a fix, no problem putting it in with this one. |
|
I fixed this in the 3.12 backport (#118011). I though that it was due to some changes between 3.12 and main that the tests were passed in main, but it turned out they were simply skipped. |
erlend-aasland
requested review from
zooba
and removed request for
erlend-aasland
|
I'm fine with this, but someone with Windows knowledge should approve. |
serhiy-storchaka
approved these changes
Apr 29, 2024
zooba
reviewed
Apr 29, 2024
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_capisurprisingly skipped on Windows #118351