Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: Don't specialize RESUME_CHECK when specialization is disabled #118349

Merged
merged 5 commits into from Apr 30, 2024

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Apr 27, 2024

It was showing up as a race in tsan. Though other races still bubble up with vectorcall so we cant remove it from the ignore list for now.

@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review April 27, 2024 16:24
@Fidget-Spinner Fidget-Spinner changed the title Disable RESUME_CHECK specialization on free-threaded builds gh-117657: Disable RESUME_CHECK specialization on free-threaded builds Apr 27, 2024
Copy link
Member

@swtaarrs swtaarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but it might make sense to change the title to something like "Don't specialize RESUME_CHECK when specialization is disabled", which is what this is really doing. It's a good fix independent of free-threading concerns.

@Fidget-Spinner Fidget-Spinner changed the title gh-117657: Disable RESUME_CHECK specialization on free-threaded builds gh-117657: Don't specialize RESUME_CHECK when specialization is disabled Apr 30, 2024
@Fidget-Spinner
Copy link
Member Author

@DinoV made this atomic but we should still disable this if specialization is off anyways, for consistency's sake.

@Fidget-Spinner Fidget-Spinner enabled auto-merge (squash) April 30, 2024 21:25
@Fidget-Spinner Fidget-Spinner merged commit 7fabcc7 into python:main Apr 30, 2024
52 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit 7fabcc7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1380/builds/134) and take a look at the build logs.
  4. Check if the failure is related to this commit (7fabcc7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1380/builds/134

Failed tests:

  • test_posix

Failed subtests:

  • test_confstr - test.test_posix.PosixTester.test_confstr

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/AEE8DE28-E153-4624-933C-E9440AD6F955/data/Containers/Bundle/Application/02D17676-135F-425E-BBA6-933A29FA2609/iOSTestbed.app/python/lib/python3.13/test/test_posix.py", line 569, in test_confstr
    self.assertEqual(len(posix.confstr("CS_PATH")) > 0, True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants