Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118335: Configure Tier 2 interpreter at build time #118339

Merged
merged 42 commits into from May 1, 2024
Merged

gh-118335: Configure Tier 2 interpreter at build time #118339

merged 42 commits into from May 1, 2024

Commits on Apr 26, 2024

  1. Step 1: replace 'python -Xuops' with 'configure --enable-experimental… 

    …-tier2'
    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1eb8fea View commit details
    Browse the repository at this point in the history

  2. Make JIT imply TIER2, for convenience

    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0863c17 View commit details
    Browse the repository at this point in the history

  3. Step 2: Remove all code from optimizer*.c unless TIER2; fix deps exce… 

    …pt _testinternalcapi
    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9e43331 View commit details
    Browse the repository at this point in the history

  4. Remove TIER2 stuff from _testinternalcapi

    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    064de58 View commit details
    Browse the repository at this point in the history

  5. Fix test_dis.py: _opcode.get_executor() may raise RuntimeError

    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    13b8ef0 View commit details
    Browse the repository at this point in the history

  6. Fix test_regrtest (by tweaking without_getoptimizer)

    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    edbaeef View commit details
    Browse the repository at this point in the history

  7. Fix test_optimizer.py

    @gvanrossum
    gvanrossum committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9311198 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Fix test_opcache

    @gvanrossum
    gvanrossum committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    300ae6d View commit details
    Browse the repository at this point in the history

  2. Fix test_monitoring

    @gvanrossum
    gvanrossum committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    db911e4 View commit details
    Browse the repository at this point in the history

  3. Fix test_capi.test_opt (by disabling unless get_optimizer exists)

    @gvanrossum
    gvanrossum committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    8cb71dd View commit details
    Browse the repository at this point in the history

  4. Fix _opcode.c

    @gvanrossum
    gvanrossum committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7e79509 View commit details
    Browse the repository at this point in the history

  5. Fix warning in sysmodule.c

    @gvanrossum
    gvanrossum committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    638b7ec View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. When compiling _testinternalcapi.c, define _Py_JIT

    @gvanrossum
    gvanrossum committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8fc905f View commit details
    Browse the repository at this point in the history

  2. Try making WASI Debug recursion limit 400

    @gvanrossum
    gvanrossum committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    877a005 View commit details
    Browse the repository at this point in the history

  3. Merge main into tier2-flag

    @gvanrossum
    gvanrossum committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e4464d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Revert "Try making WASI Debug recursion limit 400" 

    It doesn't work. I'm giving up.

This reverts commit 877a005.
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ffd7722 View commit details
    Browse the repository at this point in the history

  2. Update jit/README.md to require LLVM 18 everywhere

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6e2777b View commit details
    Browse the repository at this point in the history

  3. Rip out --enable-experimental-tier2, in favor of --enable-experimenta… 

    …l-jit=XXX

There's more to do.
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f228a06 View commit details
    Browse the repository at this point in the history

  4. Rip out _Py_TIER2, replace with _Py_JIT 

    The value is a bitflag:
- 0: off
- 1: JIT, on by default
- 3: JIT, off by default (not yet implemented, requires fiddling pystate.c)
- 4: tier 2 interpreter, on by default
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    70e18a5 View commit details
    Browse the repository at this point in the history

  5. configure: set _Py_JIT={1|3|4} (for now)

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    17f1674 View commit details
    Browse the repository at this point in the history

  6. Try making WASI Debug recursion limit 300

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e23c688 View commit details
    Browse the repository at this point in the history

  7. Revert "Rip out _Py_TIER2, replace with _Py_JIT" 

    This reverts commit 70e18a5.
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ebd8025 View commit details
    Browse the repository at this point in the history

  8. Make the configure script set both _Py_JIT and _Py_TIER2, as appropriate

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e367c27 View commit details
    Browse the repository at this point in the history

  9. Pass flag bit in _Py_TIER2 instead of _Py_JIT

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8681813 View commit details
    Browse the repository at this point in the history

  10. Honor default-off and PYTHON_JIT=0|1

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8f89b3b View commit details
    Browse the repository at this point in the history

  11. Add interpreter-default-off as secret menu item

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fe94220 View commit details
    Browse the repository at this point in the history

  12. Revert "Try making WASI Debug recursion limit 300" 

    It seems to make no difference.

This reverts commit e23c688.
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2963ccb View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/main' into tier2-flag

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    783c3cc View commit details
    Browse the repository at this point in the history

  14. Also predefine _Py_TIER2 on Windows if UseJIT is true

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f45f7ca View commit details
    Browse the repository at this point in the history

  15. Trashcan consumes more C stack (experimental, targeting WASI Debug bu… 

    …ild)
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    391bd46 View commit details
    Browse the repository at this point in the history

  16. Update what's new for new --enable-experimental-jit options

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c5d8c0a View commit details
    Browse the repository at this point in the history

  17. Revert "Trashcan consumes more C stack (experimental, targeting WASI … 

    …Debug build)"

This doesn't work either.

This reverts commit 391bd46.
    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f45bf67 View commit details
    Browse the repository at this point in the history

  18. Just disable test_trashcan_16602 on WASI Debug builds

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a6cc5ee View commit details
    Browse the repository at this point in the history

  19. Fix test_weakref :-(

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    35cb5bd View commit details
    Browse the repository at this point in the history

  20. Shorten to --enable-exerimental-jit=yes-off

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8276a9a View commit details
    Browse the repository at this point in the history

  21. Tweak code in test/support/__init__.py without_optimizer()

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f950e25 View commit details
    Browse the repository at this point in the history

  22. Fix news blurb

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6be70c0 View commit details
    Browse the repository at this point in the history

  23. Fix typo in _opcode.c

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fdbe440 View commit details
    Browse the repository at this point in the history

  24. Shut up annoying warning

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3c919bb View commit details
    Browse the repository at this point in the history

  25. Use Py_FatalError for ENTER_EXECUTOR in non-TIER2 build

    @gvanrossum
    gvanrossum committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d5a3ff0 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Add --experimental-jit-{off|interpreter} to PCbuild/build.bat

    @gvanrossum
    gvanrossum committed May 1, 2024
    Configuration menu
    Copy the full SHA
    07c485e View commit details
    Browse the repository at this point in the history

  2. Revert "Shut up annoying warning" 

    Apparently makes the CI fuzzer unhappy.

This reverts commit 3c919bb.
    @gvanrossum
    gvanrossum committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a2d4f30 View commit details
    Browse the repository at this point in the history