gh-118314: Fix padding edge case in binascii.a2b_base64 strict mode #118320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhangyoufu
commented
Apr 26, 2024
•
zhangyoufu
commented
- Issue: binascii.a2b_base64 strict mode accepts invalid base64 input #118314
eendebakpt
reviewed
Apr 26, 2024
Misc/NEWS.d/next/Library/2024-04-26-12-42-29.gh-issue-118314.Z7reGc.rst
Outdated
Show resolved
Hide resolved
…7reGc.rst Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
terryjreedy
reviewed
Apr 26, 2024
There was a problem hiding this comment.
@serhiy-storchaka Except for consideration of my comment below, this looks good to me. I don't know whether you are someone else is best to review/merge.
|
@terryjreedy Please add |
|
Thanks @zhangyoufu for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 7, 2024
…mode (pythonGH-118320) Fix an edge case in `binascii.a2b_base64` strict mode, where excessive padding was not detected when no padding is necessary. (cherry picked from commit fe47d9b) Co-authored-by: Youfu Zhang <1315097+zhangyoufu@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
|
GH-118691 is a backport of this pull request to the 3.12 branch. |
encukou
pushed a commit
that referenced
this pull request
May 7, 2024
… mode (GH-118320) (GH-118691) gh-118314: Fix padding edge case in binascii.a2b_base64 strict mode (GH-118320) Fix an edge case in `binascii.a2b_base64` strict mode, where excessive padding was not detected when no padding is necessary. (cherry picked from commit fe47d9b) Co-authored-by: Youfu Zhang <1315097+zhangyoufu@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…mode (pythonGH-118320) Fix an edge case in `binascii.a2b_base64` strict mode, where excessive padding was not detected when no padding is necessary. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.