Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118293: Suppress mouse cursor change in multiprocessing #118315

Merged
merged 3 commits into from Apr 28, 2024

Conversation

tunedal
Copy link
Contributor

@tunedal tunedal commented Apr 26, 2024

This PR modifies multiprocessing's spawn implementation on Windows to pass the STARTF_FORCEOFFFEEDBACK flag in STARTUPINFO when calling CreateProcess, which tells Windows that the worker processes are not GUI applications being launched and to suppress the mouse cursor change that goes along with launching applications. See issue #118293.

@tunedal tunedal requested a review from gpshead as a code owner April 26, 2024 11:51
Copy link

cpython-cla-bot bot commented Apr 26, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 26, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@tunedal tunedal force-pushed the multiprocessing-cursor-fix branch 2 times, most recently from 527f7cd to bcde233 Compare April 26, 2024 23:00
Copy link
Contributor

@eryksun eryksun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Henrik.

@zooba zooba enabled auto-merge (squash) April 28, 2024 20:48
@zooba
Copy link
Member

zooba commented Apr 28, 2024

Looks good to me. If CI agrees, it should merge automatically.

@zooba zooba merged commit 133c1a7 into python:main Apr 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants