gh-116622: Redirect stdout and stderr to system log when embedded in an Android app #118063
Conversation
|
@serhiy-storchaka: This PR is connected to the |
There was a problem hiding this comment.
Thank you!
This looks good to me, modulo a few small nitpicks. I'll let @serhiy-storchaka resolve the conversations he started.
Lib/test/test_android.py
Outdated
|
|
||
| def tearDown(self): | ||
| self.logcat_process.terminate() | ||
| self.logcat_process.wait(0.1) |
Lib/test/test_android.py
Outdated
|
|
||
| # Long lines are split into blocks of 1000 *characters*, but | ||
| # TextIOWrapper should then join them back together as much as | ||
| # possible without exceeding 4000 UTF-8 *bytes*. |
There was a problem hiding this comment.
Let's leave a breadcrumb here:
| # possible without exceeding 4000 UTF-8 *bytes*. | |
| # possible without exceeding MAX_BYTES_PER_WRITE (4000) UTF-8 *bytes*. |
|
|
||
|
|
||
| static PyMethodDef android_log_write_method = { | ||
| "android_log_write", android_log_write_impl, METH_VARARGS |
There was a problem hiding this comment.
Would it be possible to use METH_FASTCALL?
There was a problem hiding this comment.
You can replace PyArg_ParseTuple() with _PyArg_ParseStack().
There was a problem hiding this comment.
I do not think that it will make significant difference in this case. It is better to use the stable public API.
There was a problem hiding this comment.
I agree: this isn't a performance-critical area.
Co-authored-by: Victor Stinner <vstinner@python.org>
|
Merged. Let's see how it goes. It can be adjusted later if needed. Nice change @mhsmith. |
…ed in an Android app (python#118063)
…ed in an Android app (python#118063)
When embedded in an app on current versions of Android, there's no easy way to monitor the process's stdout and stderr. So, as specified in PEP 738, this PR redirects them to the system log, which can be viewed using the developer tools.