Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "gh-96844: Improve error message of list.remove (gh-106455)" #116956

Merged
merged 1 commit into from Mar 18, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 18, 2024

@vstinner
Copy link
Member Author

cc @corona10

@vstinner
Copy link
Member Author

See #116792 for the rationale of the revert.

@corona10
Copy link
Member

It is pretty wired, it means that we can not use %R any other place for the same issue.

@vstinner vstinner enabled auto-merge (squash) March 18, 2024 13:44
@vstinner vstinner merged commit f6cdc6b into python:main Mar 18, 2024
40 of 41 checks passed
@vstinner vstinner deleted the revert_list_remove_repr branch March 18, 2024 13:54
@gvanrossum
Copy link
Member

Next time, please include the reason for the revert in the commit message, per our guidelines.

@vstinner
Copy link
Member Author

Next time, please include the reason for the revert in the commit message, per our guidelines.

Oh, I don't know this guideline. I just used "git revert commit". Ok, will do next time.

vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants