Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116682: stdout may be empty in test_cancel_futures_wait_false #116683

Merged
merged 1 commit into from Mar 13, 2024
Merged

gh-116682: stdout may be empty in test_cancel_futures_wait_false #116683

merged 1 commit into from Mar 13, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 12, 2024 •
edited by bedevere-app bot

If the shutdown() call happens before the worker thread starts executing the task then nothing will be printed to stdout.

@colesbury
pythongh-116682: stdout may be empty in test_cancel_futures_wait_false
0b9bfb5 
If the shutdown() call happens before the worker thread starts executing
the task then nothing will be printed to stdout.
@colesbury colesbury added skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Mar 12, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 12, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 12, 2024
erlend-aasland
erlend-aasland approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pragmatic solution is ok for a flaky test like this.

@colesbury colesbury merged commit 7d1abe9 into python:main Mar 13, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-116682-test_cancel_futures_wait_false branch March 13, 2024 00:12
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
@colesbury @miss-islington
pythongh-116682: stdout may be empty in test_cancel_futures_wait_false (
9455336 
pythonGH-116683)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
(cherry picked from commit 7d1abe9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116692 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
@colesbury @miss-islington
pythongh-116682: stdout may be empty in test_cancel_futures_wait_false (
38399bd 
pythonGH-116683)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
(cherry picked from commit 7d1abe9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116693 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 13, 2024
colesbury added a commit that referenced this pull request Mar 13, 2024
@miss-islington @colesbury
[3.11] gh-116682: stdout may be empty in test_cancel_futures_wait_fal…
a01621a 
…se (GH-116683) (#116693)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
(cherry picked from commit 7d1abe9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit that referenced this pull request Mar 13, 2024
@miss-islington @colesbury
[3.12] gh-116682: stdout may be empty in test_cancel_futures_wait_fal…
84c8925 
…se (GH-116683) (#116692)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
(cherry picked from commit 7d1abe9)

Co-authored-by: Sam Gross <colesbury@gmail.com>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@colesbury @vstinner
pythongh-116682: stdout may be empty in test_cancel_futures_wait_false (
7b2d400 
python#116683)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@colesbury @adorilson
pythongh-116682: stdout may be empty in test_cancel_futures_wait_false (
36a33b8 
python#116683)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-116682: stdout may be empty in test_cancel_futures_wait_false (
3d8f4de 
python#116683)

If the `shutdown()` call happens before the worker thread starts executing
the task, then nothing will be printed to stdout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colesbury @erlend-aasland