Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116646: Add PyLong_FileDescriptor_Converter() function #116655

Closed
wants to merge 5 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 12, 2024

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to add a macro that adds an alias to the previous underscored name.

Doc/c-api/long.rst Outdated Show resolved Hide resolved
vstinner and others added 2 commits March 12, 2024 14:02
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@vstinner
Copy link
Member Author

@erlend-aasland:

Consider to add a macro that adds an alias to the previous underscored name.

Oh, I didn't remove it on purpose, I just didn't notice the "removal".

Hum, _PyLong_FileDescriptor_Converter() is declared in the internal Include/internal/pycore_fileutils.h header in Python 3.13. Oh, it was declared in Include/cpython/fileobject.h in Python 3.12.

Ok, I added an alias in Include/cpython/fileutils.h: not in the limited C API (Include/fileutils.h).

@erlend-aasland
Copy link
Contributor

I think you need to update the stable API manifest as well: Misc/stable_abi.toml

@vstinner vstinner requested review from a team and encukou as code owners March 12, 2024 15:09
Doc/c-api/long.rst Outdated Show resolved Hide resolved
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@vstinner vstinner marked this pull request as draft March 13, 2024 16:53
@vstinner
Copy link
Member Author

See also PR #116736

@vstinner
Copy link
Member Author

I wrote #116769 which replaces this PR.

@vstinner vstinner closed this Mar 13, 2024
@vstinner vstinner deleted the fd_converter branch March 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants