Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116180: check if globals is NULL and set error in run_eval_code_obj() #116637
gh-116180: check if globals is NULL and set error in run_eval_code_obj() #116637
Changes from 36 commits
9635b76
3e97671
348d895
259034c
85d9f47
cf578bd
bba6927
1b5fe4c
a016a54
173b9ce
86c6e57
7503772
f175046
dcab696
9532797
ee0fd8a
7eca26f
08b5c3a
23b9fe6
acc7eb3
09c71a9
806d21c
907c86d
af9e9fc
56f0d3c
b1d7ab2
f8e29ce
efe064d
8f33e7a
296705a
cd58eb6
c461bd9
7db13d0
eef557c
66646e9
45cab7f
1716ac6
1a9532c
6f0a0a4
2607806
7f4c496
5974757
2b4ba12
aa73f40
f6a8ee9
ccf5871
abeea0a
d579f21
d3938f5
4a18dd2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if
filename
is NULL?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux will return something like EFAULT with fp = NULL.
And it is not NULLABLE. Anyway, filename = NULL made test fail:
But NULL can be passed, if you use fp of stdin for example