CI: Pass environment variables directly to configure in JIT CI #116156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
force-pushed
the
jit-ci
branch
2 times, most recently
from
89390c5
to
936e864
Compare
hugovk
reviewed
Mar 12, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
approved these changes
Mar 14, 2024
| CC="${{ matrix.compiler == 'clang' && 'clang --target=$HOST' || '$HOST-gcc' }}" \ | ||
| CPP="$CC --preprocess" \ | ||
| HOSTRUNNER=qemu-${{ matrix.architecture }} \ | ||
| ./configure --enable-experimental-jit ${{ matrix.debug && '--with-pydebug' || '--enable-optimizations --with-lto' }} --build=x86_64-linux-gnu --host="$HOST" --with-build-python=../build/bin/python3 --with-pkg-config=no ac_cv_buggy_getaddrinfo=no ac_cv_file__dev_ptc=no ac_cv_file__dev_ptmx=yes |
There was a problem hiding this comment.
This ~300-char line could benefit from splitting with \ too, but not directly relevant here and not a blocker.
There was a problem hiding this comment.
Agreed. Suggesting to clean up the whole workflow in a follow-up PR.
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…n#116156) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…n#116156) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…n#116156) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.