gh-111201: A new Python REPL #111567

pablogsal · 2023-10-31T17:38:56Z

Issue: A new Python REPL #111201

vstinner

You add many env vars. Can you document them in Doc/using/cmdline.rst?

Usually, env var names start with PYTHON. Should the variables be renamed?

Also, Python ignores env var starting with PYTHON if sys.flags.ignore_environment.

Lib/_pyrepl/__main__.py

Lib/_pyrepl/curses.py

Python/pythonrun.c

Lib/_pyrepl/__main__.py

vstinner · 2023-11-01T20:16:36Z

Lib/_pyrepl/_minimal_curses.py

+manually.
+
+Note that there is also a built-in module _minimal_curses which will
+hide this one if compiled in.


Is it part of this PR? If not, do you consider adding it or not?

Yes, sounds like this comment was carried over from pypy but doesn't apply here.

pablogsal · 2023-11-01T22:12:51Z

@vstinner the PR is still draft, please wait until we mark it as finished before reviewing as most of this code may change

…ambled)

…importing too much

…ssumptions

hugovk

Please also add a What's New entry.

Doc/tutorial/appendix.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

pablogsal · 2024-05-05T10:20:56Z

Please also add a What's New entry.

There is already one (Misc/NEWS.d/next/Core and Builtins/2024-04-28-00-41-17.gh-issue-111201.cQsh5U.rst)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

pablogsal · 2024-05-05T10:24:43Z

@hugovk @JelleZijlstra I have implemented your suggestions. If you have some time, do you mind reviewing again?

hugovk

Docs changes look good.

One suggestion: this PR adds the main docs to the tutorial, we should probably add something to the reference, but this could be a followup.

Please also add a What's New entry.

There is already one (Misc/NEWS.d/next/Core and Builtins/2024-04-28-00-41-17.gh-issue-111201.cQsh5U.rst)

That's the changelog, this change definitely needs highlighting in https://docs.python.org/3.13/whatsnew/3.13.html but it can also be in a followup PR.

cfbolz

Cool to see this!

Just to check, was it intentional that you didn't port PyPy's _pyrepl tests? There's not a huge amount of tests there, admittedly.

I am philosophically a little bit worried that people will start using and relying on _pyrepl internal details, which are now slightly different between PyPy and CPython, right? This could lead to PyPy's life getting somewhat harder in this area. As usual, it's hard to stop people from doing that, of course.

cfbolz · 2024-05-05T16:10:42Z

Lib/_pyrepl/reader.py

+            self.restore()
+            yield
+        finally:
+            for arg in ("msg", "ps1", "ps2", "ps3", "ps4", "paste_mode"):


why is there a discrepancy between how prev_state is constructed (which uses fields(self) and how it is used in the finally block (listing the attributes explicitly)?

It evolved into this, which you're right would now be cleaner to just reuse the list of fields.

I originally started with just dict(__dict__) but when I added typing with slots=True the __dict__ was gone so I modified it to use fields() instead.

Doc/whatsnew/3.13.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-bot · 2024-05-05T19:56:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit f27f8c7.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1223/builds/3012) and take a look at the build logs.
Check if the failure is related to this commit (f27f8c7) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1223/builds/3012

Failed tests:

test_pyrepl

Failed subtests:

test_push_without_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_without_key_in_keymap
test_flush_buf - test.test_pyrepl.TestUnivEventQueue.test_flush_buf
test_push_with_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_key_in_keymap
test_insert - test.test_pyrepl.TestUnivEventQueue.test_insert
test_get - test.test_pyrepl.TestUnivEventQueue.test_get
test_push_special_key - test.test_pyrepl.TestUnivEventQueue.test_push_special_key
test_empty - test.test_pyrepl.TestUnivEventQueue.test_empty
test_push_with_keymap_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap
test_push_with_keymap_in_keymap_and_escape - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap_and_escape
test_push_unrecognized_escape_sequence - test.test_pyrepl.TestUnivEventQueue.test_push_unrecognized_escape_sequence

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 613, in test_empty
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 625, in test_insert
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 607, in test_get
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-05-05T19:59:27Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit f27f8c7.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/7064) and take a look at the build logs.
Check if the failure is related to this commit (f27f8c7) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/7064

Failed tests:

test_pyrepl

Failed subtests:

test_push_without_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_without_key_in_keymap
test_flush_buf - test.test_pyrepl.TestUnivEventQueue.test_flush_buf
test_push_with_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_key_in_keymap
test_insert - test.test_pyrepl.TestUnivEventQueue.test_insert
test_get - test.test_pyrepl.TestUnivEventQueue.test_get
test_push_special_key - test.test_pyrepl.TestUnivEventQueue.test_push_special_key
test_empty - test.test_pyrepl.TestUnivEventQueue.test_empty
test_push_with_keymap_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap
test_push_with_keymap_in_keymap_and_escape - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap_and_escape
test_push_unrecognized_escape_sequence - test.test_pyrepl.TestUnivEventQueue.test_push_unrecognized_escape_sequence

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 625, in test_insert
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 613, in test_empty
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 607, in test_get
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

bedevere-bot · 2024-05-05T20:13:51Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Debian Clang LTO + PGO 3.x has failed when building commit f27f8c7.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1084/builds/4264) and take a look at the build logs.
Check if the failure is related to this commit (f27f8c7) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1084/builds/4264

Failed tests:

test_pyrepl

Failed subtests:

test_push_without_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_without_key_in_keymap
test_flush_buf - test.test_pyrepl.TestUnivEventQueue.test_flush_buf
test_push_with_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_key_in_keymap
test_insert - test.test_pyrepl.TestUnivEventQueue.test_insert
test_get - test.test_pyrepl.TestUnivEventQueue.test_get
test_push_special_key - test.test_pyrepl.TestUnivEventQueue.test_push_special_key
test_empty - test.test_pyrepl.TestUnivEventQueue.test_empty
test_push_with_keymap_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap
test_push_with_keymap_in_keymap_and_escape - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap_and_escape
test_push_unrecognized_escape_sequence - test.test_pyrepl.TestUnivEventQueue.test_push_unrecognized_escape_sequence

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 613, in test_empty
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 625, in test_insert
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 607, in test_get
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno

Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Marta Gómez Macías <mgmacias@google.com> Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-app bot mentioned this pull request Oct 31, 2023

A new Python REPL #111201

Open

7 tasks

vstinner reviewed Nov 1, 2023

View reviewed changes

Lib/_pyrepl/__main__.py Outdated Show resolved Hide resolved

Lib/_pyrepl/__main__.py Outdated Show resolved Hide resolved

Lib/_pyrepl/curses.py Outdated Show resolved Hide resolved

Python/pythonrun.c Show resolved Hide resolved

Lib/_pyrepl/__main__.py Outdated Show resolved Hide resolved

vstinner reviewed Nov 1, 2023

View reviewed changes

pablogsal added 8 commits April 27, 2024 18:24

pythongh-111201: A new Python REPL

2bf1505

Clean some files

35d322e

Fix history across sessions

4d2303b

Fore fixes to history

7763c05

Lukasz was wrong all along

e85d873

Implement REPL commands and remove F1 for help (curses shows that scr…

842496e

…ambled)

Restore F1 for help

1417b9b

Implement colored prompt

4c69853

pablogsal force-pushed the pyrepl branch from 3278af9 to 4c69853 Compare April 27, 2024 17:27

pablogsal and others added 13 commits April 27, 2024 18:53

WIP for paste mode

359407b

Only execute PYTHONSTARTUP when asked (we do it in main.c anyway)

85a2b35

Fixed coloring

05a8831

Do not run commands if they are shadowed

c074ca6

Move pager routines to _pyrepl, so we can use it in the REPL without …

9584b5b

…importing too much

Don't assume stupid paths or you will be tested against your stupid a…

d7ddebd

…ssumptions

<F2> shows history so you can copy it, <F3> is paste mode

2d24cd2

Do not include REPL commands in history

fe1b3ac

Add Blurb

e1abd39

Reintroduce old names to fix pydoc tests

afbeaab

Add some tests

aee9fcf

Add moar tests

77db960

Add moar tests

2a64680

pablogsal force-pushed the pyrepl branch 3 times, most recently from c34adb8 to 702b59e Compare April 28, 2024 14:47

Cleanup and refactor

5bced59

ambv requested review from ericsnowcurrently, iritkatriel, ezio-melotti and hugovk as code owners May 4, 2024 22:08

bedevere-app bot added the awaiting core review label May 4, 2024

hugovk reviewed May 5, 2024

View reviewed changes

Apply suggestions from code review

058bc7f

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

pablogsal and others added 2 commits May 5, 2024 12:21

Update Lib/_pyrepl/_minimal_curses.py

7ac9af8

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Use more specific exceptions

7422f1c

pablogsal requested review from vstinner, hugovk and JelleZijlstra May 5, 2024 10:26

hugovk approved these changes May 5, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 5, 2024

ambv added 2 commits May 5, 2024 17:11

Use better error messages

d2de559

Add to What's New

3053b39

ambv approved these changes May 5, 2024

View reviewed changes

Forgot the PyPy attribution in "What's New"

149658b

cfbolz approved these changes May 5, 2024

View reviewed changes

hugovk reviewed May 5, 2024

View reviewed changes

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved

let's never talk about this

be2a0c9

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

ambv merged commit f27f8c7 into python:main May 5, 2024
44 checks passed

bedevere-app bot removed the awaiting merge label May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-111201: A new Python REPL #111567

gh-111201: A new Python REPL #111567

pablogsal commented Oct 31, 2023 •

edited by bedevere-app bot

vstinner left a comment

vstinner Nov 1, 2023

JelleZijlstra May 4, 2024

pablogsal commented Nov 1, 2023

hugovk left a comment

pablogsal commented May 5, 2024

pablogsal commented May 5, 2024

hugovk left a comment

cfbolz left a comment

cfbolz May 5, 2024

ambv May 5, 2024

bedevere-bot commented May 5, 2024

bedevere-bot commented May 5, 2024

bedevere-bot commented May 5, 2024

gh-111201: A new Python REPL #111567

gh-111201: A new Python REPL #111567

Conversation

pablogsal commented Oct 31, 2023 • edited by bedevere-app bot

vstinner left a comment

Choose a reason for hiding this comment

vstinner Nov 1, 2023

Choose a reason for hiding this comment

JelleZijlstra May 4, 2024

Choose a reason for hiding this comment

pablogsal commented Nov 1, 2023

hugovk left a comment

Choose a reason for hiding this comment

pablogsal commented May 5, 2024

pablogsal commented May 5, 2024

hugovk left a comment

Choose a reason for hiding this comment

cfbolz left a comment

Choose a reason for hiding this comment

cfbolz May 5, 2024

Choose a reason for hiding this comment

ambv May 5, 2024

Choose a reason for hiding this comment

bedevere-bot commented May 5, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented May 5, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented May 5, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

pablogsal commented Oct 31, 2023 •

edited by bedevere-app bot