Accept GitHub issues numbered only 32426 or above (#519)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
python · Dec 29, 2023 · c9c3e4a · c9c3e4a
1 parent d752290
commit c9c3e4a
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 8 deletions.
diff --git a/blurb/blurb.py b/blurb/blurb.py
@@ -473,6 +473,8 @@ def finish_entry():
 
             no_changes = metadata.get('no changes')
 
+            lowest_possible_gh_issue_number = 32426
+
             issue_keys = {
                 'gh-issue': 'GitHub',
                 'bpo': 'bpo',
@@ -486,6 +488,9 @@ def finish_entry():
                 # we'll complain about the *first* error
                 # we see in the blurb file, which is a
                 # better user experience.
+                if key == "gh-issue" and int(value) < lowest_possible_gh_issue_number:
+                    throw(f"The gh-issue number must be {lowest_possible_gh_issue_number} or above, not a PR number.")
+
                 if key in issue_keys:
                     try:
                         int(value)

diff --git a/blurb/tests/fail/small-gh-number.rst b/blurb/tests/fail/small-gh-number.rst
@@ -0,0 +1,4 @@
+.. gh-issue: 100
+.. section: Library
+
+This is an invalid blurb. GitHub issues should be 32426 or above.
diff --git a/blurb/tests/pass/basic.rst b/blurb/tests/pass/basic.rst
@@ -1,5 +1,5 @@
 .. date: 2017-05-02
-.. gh-issue: 0
+.. gh-issue: 40000
 .. nonce: xyz
 .. section: Library
 

diff --git a/blurb/tests/pass/basic.rst.res b/blurb/tests/pass/basic.rst.res
@@ -1,5 +1,5 @@
 .. date: 2017-05-02
-.. gh-issue: 0
+.. gh-issue: 40000
 .. nonce: xyz
 .. section: Library
 

diff --git a/blurb/tests/pass/case-insensitive.rst b/blurb/tests/pass/case-insensitive.rst
@@ -1,5 +1,5 @@
 .. date: 2017-05-02
-.. GH-Issue: 0
+.. GH-Issue: 35000
 .. nonce: xyz
 .. section: Library
 

diff --git a/blurb/tests/pass/case-insensitive.rst.res b/blurb/tests/pass/case-insensitive.rst.res
@@ -1,5 +1,5 @@
 .. date: 2017-05-02
-.. gh-issue: 0
+.. gh-issue: 35000
 .. nonce: xyz
 .. section: Library
 

diff --git a/blurb/tests/pass/no-break-long-words.rst b/blurb/tests/pass/no-break-long-words.rst
@@ -1,5 +1,5 @@
 .. date: 1234
-.. gh-issue: 0
+.. gh-issue: 35000
 .. nonce: xyz
 .. section: Library
 

diff --git a/blurb/tests/pass/no-break-long-words.rst.res b/blurb/tests/pass/no-break-long-words.rst.res
@@ -1,5 +1,5 @@
 .. date: 1234
-.. gh-issue: 0
+.. gh-issue: 35000
 .. nonce: xyz
 .. section: Library
 

diff --git a/blurb/tests/pass/no-break-on-hyphens.rst b/blurb/tests/pass/no-break-on-hyphens.rst
@@ -1,5 +1,5 @@
 .. date: 7333
-.. gh-issue: 21121
+.. gh-issue: 41121
 .. nonce: ZLsRil
 .. section: Library
 

diff --git a/blurb/tests/pass/no-break-on-hyphens.rst.res b/blurb/tests/pass/no-break-on-hyphens.rst.res
@@ -1,5 +1,5 @@
 .. date: 7333
-.. gh-issue: 21121
+.. gh-issue: 41121
 .. nonce: ZLsRil
 .. section: Library