Add option to specify radius steps #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR but it's generaly a best practice to first open an issue to explain the problem. |
Allow user to specify the steps at which radius circles and labels will be drawn as, and also sets the rmax value to be a multiple of rstep. So for example a call to plot_windrose(t, r, kind='bar', normed=True, blowto=False, rstep=5) will generate radii/labels of 5,10,15 etc. I don't know if this the best way to achieve this (that is should this be part of WindroseAxes constructor or just passed around in kwargs?), it just worked for my use case.
|
@sspagnol do you want to continue working in this? If so note that I rebased against our latest code tests. We need a test for this functionality and, if you can, add means for folks accessing it via the various plotting options. |
|
Would be great to have that as an option @ocefpaf ! |
|
@simonweppe it seems that this PR is abandoned and needs some work/rebasing. Do you want to pick it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify the steps at which radius circles and labels will be drawn as, and also sets the rmax value to be a multiple of rstep. So for example a call to plot_windrose(t, r, kind='bar', normed=True, blowto=False, rstep=5) will generate radii/labels of 5,10,15 etc. I don't know if this the best way to achieve this (that is should this be part of WindroseAxes constructor or just passed around in kwargs?), it just worked for my use case.