Merge pull request #266 from jkittner/curved-box

Fix issue where sectors showed a straight line instead of a curved
python-windrose · Apr 22, 2024 · e5b2330 · e5b2330
2 parents ad285d0 + 5102055
commit e5b2330
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 0 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -38,3 +38,10 @@ jobs:
       run: |
         pytest -s -rxs -vv -Werror tests/ --mpl --mpl-generate-summary=html \
         --mpl-results-path="windrose_test_output-${{ matrix.os }}-${{ matrix.python-version }}"
+    - name: Store mpl-results
+      uses: actions/upload-artifact@v4
+      if: failure()
+      with:
+        name: "windrose_test_output-${{ matrix.os }}-${{ matrix.python-version }}"
+        path: "windrose_test_output-${{ matrix.os }}-${{ matrix.python-version }}"
+        retention-days: 1
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@
 All notable changes to this code base will be documented in this file,
 in every released version.
 
+### Version 1.x.x (unreleased)
+
+## What's Changed
+* Fix issue where sometimes the plot sectors showed a straight line instead of a curved one (#137)
+
 ### Version 1.7.0
 
 ## What's Changed

diff --git a/tests/output/df/test_bar.png b/tests/output/df/test_bar.png
diff --git a/tests/output/df/test_box.png b/tests/output/df/test_box.png
diff --git a/tests/output/func/test_wrbox.png b/tests/output/func/test_wrbox.png
diff --git a/tests/output/oo/test_windrose_stacked_histogram_normed.png b/tests/output/oo/test_windrose_stacked_histogram_normed.png
diff --git a/tests/output/oo/test_windrose_stacked_histogram_normed_calm_limit.png b/tests/output/oo/test_windrose_stacked_histogram_normed_calm_limit.png
diff --git a/tests/output/oo/test_windrose_stacked_histogram_not_normed_binned.png b/tests/output/oo/test_windrose_stacked_histogram_not_normed_binned.png
diff --git a/tests/output/oo/test_windrose_stacked_histogram_not_normed_binned_calm_limit.png b/tests/output/oo/test_windrose_stacked_histogram_not_normed_binned_calm_limit.png
diff --git a/tests/output/test_bar_from_factory.png b/tests/output/test_bar_from_factory.png
diff --git a/windrose/windrose.py b/windrose/windrose.py
@@ -642,6 +642,8 @@ def bar(self, direction, var, **kwargs):
                     zorder=zorder,
                     **kwargs,
                 )
+                # needed so the the line of the rectangle becomes curved
+                patch.get_path()._interpolation_steps = 100
                 self.add_patch(patch)
                 if j == 0:
                     self.patches_list.append(patch)
@@ -718,6 +720,8 @@ def box(self, direction, var, **kwargs):
                     zorder=zorder,
                     **kwargs,
                 )
+                # needed so the the line of the rectangle becomes curved
+                patch.get_path()._interpolation_steps = 100
                 self.add_patch(patch)
                 if j == 0:
                     self.patches_list.append(patch)