Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump build version in pyproject.toml and contributor guide #921

Merged
merged 3 commits into from
May 9, 2024

Conversation

afuetterer
Copy link
Contributor

Hi there,

I was unsure, why the build version is pinned to such an old version. Is there a reason?

What do you think about also adding build[uv] and using python -m build --installer=uv .?

Ref: https://build.pypa.io/en/stable/#python--m-build---installer

@codejedi365
Copy link
Contributor

codejedi365 commented May 9, 2024

Hi @afuetterer,

I was unsure, why the build version is pinned to such an old version. Is there a reason?

Not that I'm aware of. I think it is a by-product of not tracking the updates of the dependency especially when it is defined outside of our normal dependencies list. We have dependabot configured on the repository to automatically open PRs for bumps of dependencies but it wouldn't know to look in the build_command to detect a need to open a PR. I'm glad you brought it up as it would have gone unnoticed for quite some time.

From inspiration of what you suggested, I added on top of your branch to move the build dependency up into an optional dependency definition to prevent the problem for the future. Now Dependabot will open PRs as it does with the rest of the dependencies. Obviously this also triggered slight adjustment to the build commands to point at the new optional dependency key which improves overall maintainability. I hope you don't mind.

What do you think about also adding build[uv] and using python -m build --installer=uv .?

As for uv usage, this was new to me and I'm glad to find out about a highly performant & improved pip, however, it is still too nascent for me to trust to not cause other issues on this very popular library. I would rather wait until it releases a 1.0.0 at least.

@afuetterer
Copy link
Contributor Author

Thanks. You are right, the change I suggested would get outdated over time again. Good point to have build be monitored by dependabot as well.

@codejedi365 codejedi365 merged commit b573c4d into python-semantic-release:master May 9, 2024
7 checks passed
@afuetterer afuetterer deleted the build branch May 9, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants