fix(gha): fix missing git_commit_author definition in action
#919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
changed the title
git_committer_* definition in actiongit_commit_author definition in action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix an issue introduced in
9.7.0wheregit_commiter_email&git_commiter_namewere not passed on through to PSR when using the GitHub ActionResolve: #918
Rationale
The
GIT_COMMIT_AUTHORvariable was not exported or created in the environment which caused PSR to use the configuration file and/or default semantic-release values. It was accidentally removed during the refactor as it was not obvious of its use.How I tested
Using my test project, psr-test-gha, I was able to successfully release with the configuration defaults when no default is given and then commit with custom provided values.