Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gha)!: use composite action for semantic release (#692) #741

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bernardcooke53
Copy link
Contributor

No description provided.

@bernardcooke53
Copy link
Contributor Author

@zckv I have moved the changes from #692 over here.

I'm thinking I want to add the following to this PR (based off of the breakage in the previous one):

  • Document additional requirements for workflows now that the action isn't Dockerized
    • e.g. add a setup-python step
  • Add a workflow to test the GitHub action on runners using each of ubuntu-latest, macos-latest and windows-latest
    • I've been playing about with some usage here which I think could be a starting point
  • The entrypoint action.sh will need to be re-worked to be cross-platform, because when I ran this on windows-latest it fell over quite quickly - the easiest thing will probably be to just make it a Python script instead of shell.

Will make PRs against this branch for each of those, obviously no obligation but if you still want to work on the change would you mind doing the same please? That way it can all be merged at once 🙏

kaechele added a commit to kaechele/bonaparte that referenced this pull request Dec 29, 2023
Later versions reverted python-semantic-release/python-semantic-release#692
which breaks builds on Python projects requiring a newer interpreter
than 3.10, which their container uses.

Should be fine to update after
python-semantic-release/python-semantic-release#741
is merged again.

Signed-off-by: Felix Kaechele <felix@kaechele.ca>
@eikowagenknecht
Copy link

Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well.

@github-actions github-actions bot added the stale label Mar 25, 2024
@codejedi365 codejedi365 self-assigned this Mar 30, 2024
@codejedi365 codejedi365 removed the stale label Mar 30, 2024
@codejedi365 codejedi365 removed their assignment Mar 30, 2024
@codejedi365 codejedi365 changed the title feat!(action): use composite action for semantic release (#692) feat(gha)!: use composite action for semantic release (#692) Mar 30, 2024
Resolves: #692

Co-authored-by: Bernard Cooke <bernard-cooke@hotmail.com>
cachitas added a commit to cachitas/stringx that referenced this pull request Apr 19, 2024
@codejedi365 codejedi365 added the breaking Identifies breaking change label May 5, 2024
@codejedi365
Copy link
Contributor

Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well.

@eikowagenknecht, although this composite action has not been merged yet. #914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of 3.11 & 3.12.

@codejedi365 codejedi365 added the confirmed Prevent from becoming stale label May 6, 2024
@zckv
Copy link
Contributor

zckv commented May 6, 2024

Hello 👋

Wouldn't it be simpler to create a separate action repository ? This solution would avoid a "breaking" change on this project for something that is not related to the PSR python code.

@codejedi365
Copy link
Contributor

Wouldn't it be simpler to create a separate action repository ?

No, I don't believe so. It sounds nice up front but we would then have to keep both projects in sync. This action change would still be a breaking change which would then cause a version number drift of the version numbers of the project which likely confuses the configurations used and the users. This may not matter as the proper version is a set dependency in the action.

I plan to wrap it in with the next breaking change for the project. The release will have a full migration instructions and such with it. Maybe at the breaking change it's moved to another repository which doesn't change all that much besides the version it points to upon this repository update.

@eikowagenknecht
Copy link

@eikowagenknecht, although this composite action has not been merged yet. #914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of 3.11 & 3.12.

Thanks, working fine for 3.12 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Identifies breaking change confirmed Prevent from becoming stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants