Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0b3 #6003

Merged
merged 3 commits into from Jul 13, 2022
Merged

Release 1.2.0b3 #6003

merged 3 commits into from Jul 13, 2022

Conversation

mkniewallner
Copy link
Member

@mkniewallner mkniewallner commented Jul 12, 2022

Full diff: 1.2.0b2...master

Provisional changelog for 1.2.0b3

Important: This release fixes a critical issue that prevented hashes from being retrieved when locking dependencies, due to a breaking change on PyPI JSON API (see #5972 and the upstream change for more details).

After upgrading, you have to clear Poetry cache manually to get that feature working correctly again:

$ poetry cache clear pypi --all

Added

  • Added --only-root to poetry install to install a project without its dependencies (#5783)

Changed

  • Improved user experience of poetry init (#5838)
  • Added default timeout for all HTTP requests, to avoid hanging requests (#5881)
  • Updated poetry init to better specify how to skip adding dependencies (#5946)
  • Updated Poetry repository names to avoid clashes with user-defined repositories (#5910)

Fixed

  • Fixed an issue where extras where not handled if they did not match the case-sensitive name of the packages (#4122)
  • Fixed configuration of experimental.system-git-client option through poetry config (#5818)
  • Fixed uninstallation of git dependencies on Windows (#5836)
  • Fixed an issue where ~ was not correctly expanded in virtualenvs.path (#5848)
  • Fixed an issue where installing/locking dependencies would hang when setting an incorrect git repository (#5880)
  • Fixed an issue in poetry publish when keyring was not properly configured (#5889)
  • Fixed duplicated line output in console (#5890)
  • Fixed an issue where the same wheels where downloaded multiple times during installation (#5871)
  • Fixed an issue where dependencies hashes could not be retrieved when locking due to a breaking change on PyPI JSON API (#5973)
  • Fixed an issue where a dependency with non-requested extras could not be installed if it is requested with extras by another dependency (#5770)
  • Updated git backend to correctly read local/global git config when using dulwich as a git backend (#5935)
  • Fixed an issue where optional dependencies where not correctly exported when defining groups (#5819)

Docs

  • Fixed configuration instructions for repositories specification (#5809)
  • Added a link to dependency specification from pyproject.toml (#5815)
  • Improved zsh autocompletion instructions (#5859)
  • Improved installation and update documentations (#5857)
  • Improved exact requirements documentation (#5874)
  • Added documentation for @ operator (#5822)
  • Improved autocompletion documentation (#5879)
  • Improved scripts definition documentation (#5884)

@mkniewallner mkniewallner added the kind/release Meta-issues/PRs as part of the release process label Jul 12, 2022
@mkniewallner mkniewallner marked this pull request as ready for review July 13, 2022 06:45
@mkniewallner mkniewallner requested a review from a team July 13, 2022 06:45
@dimbleby
Copy link
Contributor

Must we have another beta?

All the issues listed as blockers in #5586 are either fixed or have fixes pending. Why not merge those fixes, and cut 1.2.0 proper?

(There are some nice-to-haves left: but there always will be - and there can be a 1.2.1 and 1.2.2 at any time...)

@mkniewallner
Copy link
Member Author

Must we have another beta?

All the issues listed as blockers in #5586 are either fixed or have fixes pending. Why not merge those fixes, and cut 1.2.0 proper?

(There are some nice-to-haves left: but there always will be - and there can be a 1.2.1 and 1.2.2 at any time...)

I agree that this release could have waited for the pending fixes, to become a proper 1.2.0. The motivation for having yet another beta mostly stems from the critical issue with the hashes that hit us last week. There are people that rely on 1.2.x despite it being a beta (which is not surprising given the number of fixes in 1.2 branch compared to 1.1), and right now their only option to have a working Poetry is to use master.

In any case, letting this release aside, I share the sentiment that next release should be a proper 1.2.0. As you said, we will always have things to add, and bugs to fix, but this can be handled in future patch versions.

@dimbleby
Copy link
Contributor

So kill two birds with one stone: get a fix out for the hashes issue, and release 1.2.0!

Seriously, why not go 1.2.0? What is the line of argument that says that poetry is not ready?

@neersighted
Copy link
Member

So kill two birds with one stone: get a fix out for the hashes issue, and release 1.2.0!

Seriously, why not go 1.2.0? What is the line of argument that says that poetry is not ready?

Mostly, we need some time to work through those as all of the core team has been fairly busy with things other than Poetry the last week or two and it's hard to commit to getting every pending PR fixed up in the next day or two. In the mean time, Poetry 1.2 beta is still broken. I think it's good to cut a beta now, with a RC to follow in 4-5 days after the pending PRs are merged.

I am going to push to get everything landed ASAP (e.g. rebasing/adding commits to people's PRs if the fixes are trivial vs waiting for author round-trips).

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You just have to add some entries for the PRs merged by @neersighted today. From my end, we might release the beta afterwards (unless someone wants to merge some more PRs before).

@mkniewallner
Copy link
Member Author

Amended first commit to include #5910 in Changed, and #5770, #5935, #5819 in Fixed.

@abn abn merged commit 93b313b into python-poetry:master Jul 13, 2022
@mkniewallner mkniewallner deleted the prepare-1.2.0b3 branch July 13, 2022 21:44
@jamessergeant
Copy link

For the record, I had to use poetry cache clear PyPI --all not poetry cache clear pypi --all

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/release Meta-issues/PRs as part of the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants