Address TODO in pyproject/tables #600
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| ) | ||
| self.requires = requires if requires is not None else ["setuptools", "wheel"] | ||
| self._dependencies: list[Dependency] | None = None | ||
| build_backend: str | None = field(default=None) |
There was a problem hiding this comment.
As it is now, I think it's a step backwards compared to the old implementation. build_backend should be of type str even if None can be passed to __init__. IMO, we should find a better solution with dataclasses or keep the old implementation and just remove the TODO.
|
|
||
| def __post_init__(self) -> None: | ||
| self.build_backend = self.build_backend or "setuptools.build_meta:__legacy__" | ||
| self.requires = self.requires or ["setuptools", "wheel"] |
There was a problem hiding this comment.
According to the old implementation self.requires should only be set to this default if it's None (not if it's an empty list). However, I assume this distinction is not necessary because each build-backend requires at least itself so there is no case where an empty list makes sense.
By the way, we should probably require setuptools >= 40.8.0. I suppose in older versions there is no "setuptools.build_meta:__legacy__", cf build
There was a TODO comment left, this addresses it.