Speed up builds with large number of git ignored files #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry checks a lot of files against the list of excluded files. If there are many files ignored by git this can severly slow down builds. Currently, if a directory is ignored by git then all files within that directory get added to set of excluded files to check.
for more information, see https://pre-commit.ci
|
Kudos, SonarCloud Quality Gate passed!
|
4 tasks
|
Hi. Our production process is impacted by this issue. Is there's a way to get this PR reviewed and hopefully merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry calls
git ls-filesagainst the package directory to get the full list of files to exclude during build. This is very slow if you have e.g. hundreds of thousands of files that are ignored (don't ask why I have that).Calling
git ls-files --directoryinstead is a lot faster, as it doesn't return all files in directories that are ignored.Doing that, however, requires refactoring
find_excluded_filesto not simply return the set of all files that are to be ignored. Instead, we return a container object that correctly handles ignored directories.This does change the API of
Builder.find_excluded_filesto return aContainer[str]rather thanset[str], but I'm not sure if that is part of any public API.