Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially handle extra version for versions constraint #409

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mkniewallner
Copy link
Member

Resolves: python-poetry/poetry#3186

  • Added tests for changed code.
  • Updated documentation for changed code.

Poetry seems to assume that all packages follow SemVer specification for versioning. However, some packages do not, as python-poetry/poetry#3186 highlights with anchor-exp.

Per PEP 440 specification, when packages define more than 3 parts for the versioning, using ~= 1.4.5.0 is equivalent to >= 1.4.5.0, == 1.4.5.*.

Poetry doesn't handle that correctly today, since defining ~= 1.4.5.0 means that we accept >= 1.4.5.0, == 1.4.*.*.

This PR is an attempt at solving this case for both ~= and wildcard operator. It is in draft for multiple reasons:

  • It only handles one more level, which is useful for dependencies using a 4-parts versioning, but it still doesn't handle versioning using more than 4 parts (which I don't think is common, but this could still happen in theory).
  • it only handles ~= and wildcard operators, but what about other ones? Per the documentation, ^ is only for SemVer, but this is less clear for ~, though given how it works, it also doesn't seem to be a good fit with something else than SemVer.
  • Finally, since this would be a breaking change in the constraints handling, I'm not sure we want to introduce this change.

Side note: python-poetry/poetry#3186 also highlights the fact that ~= is undocumented in Poetry. Is there a particular reason to not document it, or would a PR documenting it would be accepted?

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants