Generic SQL (using pyodbc) core - initial work #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Borda
reviewed
Mar 18, 2024
| @@ -189,6 +200,8 @@ def cachier( | |||
| # Override the backend parameter if a mongetter is provided. | |||
| if callable(mongetter): | |||
| backend = "mongo" | |||
| if odbc_connection_string is not None: | |||
There was a problem hiding this comment.
this could be reason why also local test are failing
|
I haven't even tested it yet. :) The test coverage is really bad (ChatGPT was lazy). |
miss-click, could you pls dismiss my review yet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @Borda , I wanted to play with ChatGPT for code contribution. I don't know if I'm going to put more work into this, but you can take a look if you want.